Skip to content

Plugin repository index pydantic models #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Aug 2, 2023
Merged

Plugin repository index pydantic models #3550

merged 21 commits into from
Aug 2, 2023

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Adds pydantic models AgentPluginRepositoryIndex and AgentPluginMetadata
Fixes #3413

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

mssalvatore
mssalvatore requested changes Aug 2, 2023
View reviewed changes
mssalvatore
mssalvatore requested changes Aug 2, 2023
View reviewed changes
monkey/common/agent_plugins/agent_plugin_metadata.py Outdated
Attributes:
:param name: Plugin name
:param type: Plugin type
:param resource_path: Path of the plugin file in the AWS S3 bucket
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data structure shouldn't make assumptions about what service is used to serve it.

shreyamalviya and others added 21 commits August 2, 2023 12:04
@shreyamalviya @mssalvatore
Common: Add AgentPluginMetadata
8447b0f
@shreyamalviya @mssalvatore
Common: Add AgentPluginRepositoryIndex
36cc030
@shreyamalviya @mssalvatore
Common: Sort plugins by version in AgentPluginRepositoryIndex
db873d6
@shreyamalviya @mssalvatore
Common: Make small fixes inAgentPluginMetadata and AgentPluginReposit…
81fe064 
…oryIndex

- Allow arbitrary types in both
- Fix plugin sorting logic in AgentPluginRepositoryIndex
@shreyamalviya @mssalvatore
Common: Add json_encoders and validators to AgentPluginMetadata
8fbb2fc
@shreyamalviya @mssalvatore
Common: Fix and improve logic in AgentPluginRepositoryIndex
0b8fe62
@shreyamalviya @mssalvatore
UT: Add tests for AgentPluginRepositoryIndex and AgentPluginMetadata
e998d0b
@shreyamalviya @mssalvatore
Project: Add plugin repository Vulture allowlist entries
4dec320
@shreyamalviya @mssalvatore
Common: Remove redundant code in AgentPluginRepositoryIndex.Config
b4e3052
@shreyamalviya @mssalvatore
UT: Improve test for AgentPluginRepositoryIndex.plugins sorting
566bdce
@mssalvatore
Common: Move types/plugin_types.py classes to agent_plugin_manifest.py
88be61d 
Define things close to where they're used.
@mssalvatore
Common: Use PluginName for AgentPluginMetadata.name
b0af5b7
@mssalvatore
Common: Subclass IMBaseModel in AgentPluginMetadata.Config
feffcbe
@mssalvatore
Common: Use PluginVersion for AgentPluginMetadata.version
78bec69
@mssalvatore
Common: Use str instead of dict to serialize semantic versions
bafd59b
@mssalvatore
Common: Use str instead of dict to serialize semantic versions
d941fc5
@mssalvatore
Common: Resolve typing error with json_encoders
70bdcc5
@mssalvatore
Common: Raise TypeError on invalid type in AgentPluginMetadata
a695e5a
@mssalvatore
Common: Use specific types in plugins dict
442ca2e
@mssalvatore
Common: Subclass IMBaseModel in AgentPluginRepositoryIndex.Config
35d6ca9
@mssalvatore
Common: Reduce the scope of resource_path docstring
8863427 
The AgentPluginMetadata class shouldn't make assumptions about how
plugins are stored.
@mssalvatore mssalvatore force-pushed the 3413-plugin-repository-index branch from 7387331 to 8863427 Compare August 2, 2023 16:04
@mssalvatore mssalvatore merged commit 480cf17 into develop Aug 2, 2023
@mssalvatore mssalvatore deleted the 3413-plugin-repository-index branch August 2, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define a Plugin repository index schema
2 participants
@shreyamalviya @mssalvatore