-
Notifications
You must be signed in to change notification settings - Fork 807
3243 arbitrary bytes #3332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3243 arbitrary bytes #3332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have just two commits, one with a temp message. Not really enough for these changes.
0251db9
to
31034a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the masque is set via the API directly, instead of via the UI as an intermediary, the UI will not display the bytes set by the API, because the API caller will not be aware of the prefixes that the UI uses to distinguish strings from base64. If the UI receives a masque without the requisite prefixes, it should assume all data is "arbitrary" and display is as base64..
I'm not sure we need a list of base64 strings. The idea here was to keep the UI simpler. The user needs to be able to specify a list of strings so they don't need to worry about string termination (null characters). For base 64, we really just need one text area that the user can paste arbitrary data into.
uniqueItems: true, | ||
items: {'type': 'string'}, | ||
default: DEFAULT_MASQUES.linux.texts, | ||
description: 'List of masque strings that will be applied to the Linux Agent binary.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we have List of masque strings
and the title is Texts
. I think we should be consistent with the terminology everywhere.
Update the masquerade schema to have another field type (base64 textarea)
Start of code generalization process and support base64 masque option
Align code to use the new getMasqueradesBytesArrays function from MasqueradeUtils
If no prefixes found it will treat the bytes as Base64
095f606
to
03082d8
Compare
What does this PR do?
Fixes #3243
PR Checklist
Testing Checklist