Skip to content

Conversation

ordabach
Copy link
Contributor

@ordabach ordabach commented May 14, 2023

What does this PR do?

Fixes #3243

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Copy link
Contributor

@ilija-lazoroski ilija-lazoroski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have just two commits, one with a temp message. Not really enough for these changes.

@ordabach ordabach force-pushed the 3243-arbitrary-bytes branch 3 times, most recently from 0251db9 to 31034a8 Compare May 15, 2023 12:06
@ordabach ordabach marked this pull request as ready for review May 15, 2023 13:32
@ordabach ordabach requested a review from ilija-lazoroski May 15, 2023 13:45
Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the masque is set via the API directly, instead of via the UI as an intermediary, the UI will not display the bytes set by the API, because the API caller will not be aware of the prefixes that the UI uses to distinguish strings from base64. If the UI receives a masque without the requisite prefixes, it should assume all data is "arbitrary" and display is as base64..

I'm not sure we need a list of base64 strings. The idea here was to keep the UI simpler. The user needs to be able to specify a list of strings so they don't need to worry about string termination (null characters). For base 64, we really just need one text area that the user can paste arbitrary data into.

uniqueItems: true,
items: {'type': 'string'},
default: DEFAULT_MASQUES.linux.texts,
description: 'List of masque strings that will be applied to the Linux Agent binary.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we have List of masque strings and the title is Texts. I think we should be consistent with the terminology everywhere.

@mssalvatore mssalvatore merged commit 968bcd5 into develop May 16, 2023
@mssalvatore mssalvatore deleted the 3243-arbitrary-bytes branch May 16, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable the user to add arbitrary bytes to the agent's masque
3 participants