Skip to content

3231 resolve hostname with dashes #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2023
Merged

3231 resolve hostname with dashes #3352

merged 2 commits into from
May 17, 2023

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Fixes #3231.

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

shreyamalviya
shreyamalviya requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@shreyamalviya shreyamalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the commit message to something more helpful/descriptive too.

ilija-lazoroski added a commit that referenced this pull request May 17, 2023
@ilija-lazoroski
Common: Resolve scan target hostnames with dashes
b456c8d 
Issue: #3231
PR: #3352
@ilija-lazoroski ilija-lazoroski force-pushed the 3231-resolve-hostname-with-dashes branch 2 times, most recently from 2a42b20 to d37ce35 Compare May 17, 2023 12:03
mssalvatore
mssalvatore requested changes May 17, 2023
View reviewed changes
ilija-lazoroski added a commit that referenced this pull request May 17, 2023
@ilija-lazoroski
Common: Resolve scan target hostnames with dashes
3e59e67 
Issue: #3231
PR: #3352
@ilija-lazoroski ilija-lazoroski force-pushed the 3231-resolve-hostname-with-dashes branch from d37ce35 to 624eabe Compare May 17, 2023 13:06
@ilija-lazoroski ilija-lazoroski force-pushed the 3231-resolve-hostname-with-dashes branch from 624eabe to 82748b0 Compare May 17, 2023 13:06
@mssalvatore mssalvatore merged commit 767e7c3 into develop May 17, 2023
@mssalvatore mssalvatore deleted the 3231-resolve-hostname-with-dashes branch May 17, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyamalviya shreyamalviya shreyamalviya requested changes

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scan target hostnames with dashes are not resolved
3 participants
@ilija-lazoroski @mssalvatore @shreyamalviya