Skip to content

3167 run credentials collectors as plugins #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2023
Merged

3167 run credentials collectors as plugins #3260

merged 3 commits into from
Apr 27, 2023

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Apr 26, 2023 •
edited
Loading

What does this PR do?

Fixes part of #3167 .

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@ilija-lazoroski ilija-lazoroski force-pushed the 3167-ui-credentials-collectors branch from d50d8a2 to 8dedccb Compare April 27, 2023 08:36
@ilija-lazoroski ilija-lazoroski force-pushed the 3167-run-credentials-collectors-as-plugins branch from de82d23 to a077210 Compare April 27, 2023 08:36
@ilija-lazoroski ilija-lazoroski mentioned this pull request Apr 27, 2023
Merged
12 tasks
@mssalvatore mssalvatore merged commit 88b38f9 into 3167-ui-credentials-collectors Apr 27, 2023
mssalvatore added a commit that referenced this pull request Apr 27, 2023
@mssalvatore
Merge branch '3167-run-credentials-collectors-as-plugins' into 3167-u…
d0f038c 
…i-credentials-collectors

Issue #3167
PR #3260
@mssalvatore mssalvatore deleted the 3167-run-credentials-collectors-as-plugins branch April 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

@shreyamalviya shreyamalviya shreyamalviya approved these changes

@cakekoa cakekoa Awaiting requested review from cakekoa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilija-lazoroski @mssalvatore @shreyamalviya