3198 remove sshguard #3259
Merged
3198 remove sshguard #3259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sshguard is preinstalled on the Ubuntu 18.04 base image. sshguard will block IPs temporarily if too many failed login attempts are made within a given time period, in order to prevent brute-force attacks. Since we want to test brute-force attacks, we are removing sshguard from these machines.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #3259 +/- ##
===========================================
+ Coverage 73.13% 73.34% +0.21%
===========================================
Files 467 480 +13
Lines 13681 13871 +190
===========================================
+ Hits 10005 10174 +169
- Misses 3676 3697 +21 ☔ View full report in Codecov by Sentry. |
mssalvatore
approved these changes
Apr 26, 2023
Comment on lines
+21
to
+24
| - name: Remove sshguard | ||
| apt: | ||
| name: sshguard | ||
| state: absent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3198.
Removes sshguard, which was preventing brute-forcing over SSH, and causing our depth_4 test to fail.
PR Checklist
Testing Checklist