Skip to content

3241 reset masque on mode change #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2023
Merged

3241 reset masque on mode change #3257

merged 2 commits into from
Apr 26, 2023

Conversation

mssalvatore
Copy link
Collaborator

What does this PR do?

Issue #3241

Subscribe to SET_ISLAND_MODE events and reset the masque

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by running manually

@mssalvatore mssalvatore mentioned this pull request Apr 26, 2023
Merged
10 tasks
@mssalvatore mssalvatore merged commit 2904cf2 into develop Apr 26, 2023
@mssalvatore mssalvatore deleted the 3241-reset-masque-on-mode-change branch April 26, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mssalvatore @ilija-lazoroski