Set masque in depth_1_a and depth_4_a tests #3256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
reviewed
Apr 26, 2023
| @@ -113,6 +122,7 @@ def reset_island(self): | |||
| self._reset_simulation_data() | |||
| self._reset_credentials() | |||
| self._reset_island_mode() | |||
| self.set_masque(b"") | |||
There was a problem hiding this comment.
I think when the endpoint to reset the island mode is called, this should happen automatically. I'm working on a PR for that.
There was a problem hiding this comment.
This is now unnecessary due to PR #3257. That being said, I don't mind leaving it. It's explicit.
4684695 to
7f8f315
Compare
7f8f315 to
d7c6acc
Compare
mssalvatore
approved these changes
Apr 26, 2023
Masque must be set after the island mode, otherwise it will get cleared.
d7c6acc to
b6baa64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3241
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?Any other testing performed?If applicable, add screenshots or log transcripts of the feature working