Skip to content

Agent binary masque resource #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 26, 2023
Merged

Agent binary masque resource #3249

merged 8 commits into from
Apr 26, 2023

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Apr 25, 2023 •
edited
Loading

What does this PR do?

Fixes a part of #3241

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested endpoints with Postman

  • If applicable, add screenshots or log transcripts of the feature working

mssalvatore
mssalvatore requested changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

@shreyamalviya shreyamalviya force-pushed the 3241-masque-resource branch 2 times, most recently from 1e51e40 to 3b25de6 Compare April 25, 2023 13:55
@mssalvatore
Copy link
Collaborator

Since we decided to change the IAgentBinaryService interface, most of that work in this PR isn't very useful. The resources also need to be completely reworked because they're using JSON and strings instead of octets. I'll leave this PR here for a bit as a draft. We can cherry-pick from it as-needed.

@mssalvatore mssalvatore marked this pull request as draft April 25, 2023 14:17
@shreyamalviya shreyamalviya force-pushed the 3241-masque-resource branch 3 times, most recently from 8aef820 to 91530c0 Compare April 26, 2023 10:50
@shreyamalviya shreyamalviya marked this pull request as ready for review April 26, 2023 10:53
mssalvatore
mssalvatore approved these changes Apr 26, 2023
View reviewed changes
mssalvatore
mssalvatore requested changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval was accidental. Small changes requested.

@mssalvatore mssalvatore merged commit f5169e4 into develop Apr 26, 2023
@mssalvatore mssalvatore deleted the 3241-masque-resource branch April 26, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski left review comments

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreyamalviya @mssalvatore @ilija-lazoroski