UI: Add a logout button #3134
Merged
UI: Add a logout button #3134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VakarisZ
commented
Mar 22, 2023
| @@ -227,7 +227,9 @@ class AppComponent extends AuthComponent { | |||
| onStatusChange: this.updateStatus, | |||
| islandMode: this.state.islandMode, | |||
| defaultReport: this.getDefaultReport(), | |||
| sideNavHeader: this.getIslandModeTitle()} | |||
| sideNavHeader: this.getIslandModeTitle(), | |||
| onLogout: () => {this.auth.logout() | |||
There was a problem hiding this comment.
Not sure this actually invalidates all tokens, but also not sure we need to do that
There was a problem hiding this comment.
Turns out it doesn't
mssalvatore
approved these changes
Mar 22, 2023
b99336b to
ff0e665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3063
Add any further explanations here.
PR Checklist
Testing Checklist
Added relevant unit tests?
Do all unit tests pass?
Do all end-to-end tests pass?
Any other testing performed?
If applicable, add screenshots or log transcripts of the feature working