Skip to content

Agent: Remove caching from get_agent_id() #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

Agent: Remove caching from get_agent_id() #3162

merged 1 commit into from
Mar 28, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Mar 28, 2023

What does this PR do?

Fixes #3119.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@cakekoa cakekoa force-pushed the 3119-get_agent_id branch from bb94930 to a1bfc9c Compare March 28, 2023 15:22
@codecov
Copy link

codecov bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (eb3abd8) 72.33% compared to head (a1bfc9c) 72.32%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3162      +/-   ##
===========================================
- Coverage    72.33%   72.32%   -0.01%     
===========================================
  Files          462      462              
  Lines        13203    13200       -3     
===========================================
- Hits          9550     9547       -3     
  Misses        3653     3653

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mssalvatore mssalvatore merged commit b7c32eb into develop Mar 28, 2023
@mssalvatore mssalvatore deleted the 3119-get_agent_id branch March 28, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent IDs are inconsistent
2 participants
@cakekoa @mssalvatore