Skip to content

2952 smb exploiter #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2023
Merged

2952 smb exploiter #3094

merged 5 commits into from
Mar 13, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Mar 10, 2023

What does this PR do?

Fixes #2952.

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

VakarisZ
VakarisZ reviewed Mar 13, 2023
View reviewed changes
monkey/agent_plugins/exploiters/smb/src/plugin.py
**kwargs,
) -> ExploiterResultData:
# HTTP ports options are hack because they are needed in fingerprinters
del_key(options, "http_ports")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we delete this? If this exploiter doesn't use it, just ignore?

Copy link
Contributor

@ilija-lazoroski ilija-lazoroski Mar 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we parse the options dict to the specific exploiter pydantic options. If the passed options have http_ports inside then it throws an error.

@shreyamalviya shreyamalviya changed the base branch from develop to 2952-smb-exploiter-plugin March 13, 2023 11:28
@shreyamalviya shreyamalviya force-pushed the 2952-smb-exploiter branch 2 times, most recently from b3e2c7b to 38dad20 Compare March 13, 2023 12:43
@cakekoa cakekoa force-pushed the 2952-smb-exploiter-plugin branch from 0745410 to b00f475 Compare March 13, 2023 12:48
@cakekoa cakekoa force-pushed the 2952-smb-exploiter branch from 38dad20 to 59409f6 Compare March 13, 2023 12:51
cakekoa and others added 4 commits March 13, 2023 13:08
@cakekoa
SMB: Partially implement SMB exploiter plugin's plugin.py
fd049be
@shreyamalviya @cakekoa
SMB: Parse exploiter options
143a50d
@shreyamalviya @cakekoa
SMB: Initialize exploiter
2ec8e6d 
The exploit client doesn't exist yet so this won't work right now
@shreyamalviya @cakekoa
SMB: Add logic to run exploiter
1db55c1 
The exploit client doesn't exist yet so this won't work right now
@cakekoa cakekoa force-pushed the 2952-smb-exploiter branch from 59409f6 to 1db55c1 Compare March 13, 2023 13:08
shreyamalviya
shreyamalviya requested changes Mar 13, 2023
View reviewed changes
@ilija-lazoroski ilija-lazoroski marked this pull request as ready for review March 13, 2023 13:38
@cakekoa cakekoa merged commit 5e8bf0c into 2952-smb-exploiter-plugin Mar 13, 2023
@ilija-lazoroski ilija-lazoroski deleted the 2952-smb-exploiter branch March 13, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ left review comments

@shreyamalviya shreyamalviya shreyamalviya requested changes

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate the SMB exploiter to a plugin
4 participants
@cakekoa @ilija-lazoroski @VakarisZ @shreyamalviya