Skip to content

2914 map sidepane fix #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2023
Merged

2914 map sidepane fix #2917

merged 3 commits into from
Feb 2, 2023

Conversation

VakarisZ
Copy link
Contributor

@VakarisZ VakarisZ commented Feb 2, 2023

What does this PR do?

Fixes #2914

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by manual run, clicking, dragging, etc.

  • If applicable, add screenshots or log transcripts of the feature working

VakarisZ
VakarisZ commented Feb 2, 2023
View reviewed changes
CHANGELOG.md
Comment on lines -157 to -158
- A bug where T1216_random_executable.exe was copied to disk even if the signed
script proxy execution PBA was disabled. #1864
Copy link
Contributor Author

@VakarisZ VakarisZ Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the PR, but pretty small change

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 66.33% // Head: 66.34% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bc1e304) compared to base (09654b9).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2917   +/-   ##
========================================
  Coverage    66.33%   66.34%           
========================================
  Files          424      424           
  Lines        12237    12269   +32     
========================================
+ Hits          8118     8140   +22     
- Misses        4119     4129   +10
Impacted Files Coverage Δ
.../monkey/infection_monkey/puppet/plugin_registry.py 90.14% <0.00%> (-3.80%) ⬇️
monkey/monkey/common/utils/windows_permissions.py 0.00% <0.00%> (ø)
monkey/monkey/tests/monkey_island/utils.py 41.37% <0.00%> (+2.66%) ⬆️
...monkey/common/utils/file_utils/secure_directory.py 72.54% <0.00%> (+11.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mssalvatore
mssalvatore reviewed Feb 2, 2023
View reviewed changes
CHANGELOG.md
Comment on lines +157 to +158
- A bug in the map where side pane would not appear if the node was
dragged around before click. #2914
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this bug present in the last release? Or did we introduce it since then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the code it was always here, that's why I added the entry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line you changed was added in #2462.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After being removed in #2460 first. Never mind, it was most likely always there.

@VakarisZ VakarisZ merged commit 0d9c9c7 into develop Feb 2, 2023
@VakarisZ VakarisZ deleted the 2914-map-sidepane-fix branch February 2, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore left review comments

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

@shreyamalviya shreyamalviya shreyamalviya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Side pane does not appear
4 participants
@VakarisZ @ilija-lazoroski @mssalvatore @shreyamalviya