Skip to content

2136 replace targethost services #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 22, 2023
Merged

2136 replace targethost services #2999

merged 17 commits into from
Feb 22, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Feb 21, 2023

What does this PR do?

Fixes part of #2136.

Replaces TargetHost.services

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@cakekoa cakekoa changed the base branch from develop to 2136-refactor-scanning February 21, 2023 23:45
@codecov
Copy link

codecov bot commented Feb 21, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (2136-refactor-scanning@58cdc1f). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head e5413e0 differs from pull request most recent head f6a7b0d. Consider uploading reports for the commit f6a7b0d to get more accurate results

Additional details and impacted files 
@@                    Coverage Diff                    @@
##             2136-refactor-scanning    #2999   +/-   ##
=========================================================
  Coverage                          ?   66.69%           
=========================================================
  Files                             ?      424           
  Lines                             ?    12348           
  Branches                          ?        0           
=========================================================
  Hits                              ?     8235           
  Misses                            ?     4113           
  Partials                          ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ilija-lazoroski
ilija-lazoroski reviewed Feb 22, 2023
View reviewed changes
@shreyamalviya shreyamalviya force-pushed the 2136-replace-targethost-services branch from e5413e0 to 869f803 Compare February 22, 2023 08:39
@shreyamalviya shreyamalviya changed the base branch from 2136-refactor-scanning to 2136-modify-master-propagator February 22, 2023 08:40
shreyamalviya
shreyamalviya requested changes Feb 22, 2023
View reviewed changes
@shreyamalviya shreyamalviya force-pushed the 2136-replace-targethost-services branch from 869f803 to 40d3786 Compare February 22, 2023 09:15
@shreyamalviya shreyamalviya marked this pull request as ready for review February 22, 2023 10:49
@shreyamalviya shreyamalviya mentioned this pull request Feb 22, 2023
Closed
11 tasks
Base automatically changed from 2136-modify-master-propagator to 2136-refactor-scanning February 22, 2023 12:30
mssalvatore
mssalvatore reviewed Feb 22, 2023
View reviewed changes
cakekoa and others added 17 commits February 22, 2023 09:16
@cakekoa @mssalvatore
Agent: Replace TargetHost.services in WebRCE
ce02d73
@cakekoa @mssalvatore
Agent: Replace TargetHost.services in SSHExploiter
6c9749c
@cakekoa @mssalvatore
Agent: Replace TargetHost.services in PowerShellExploiter
854cece
@cakekoa @mssalvatore
UT: Update test fixtures for Powershell
d4c38a6
@cakekoa @mssalvatore
Agent: Remove TargetHost.services in Propagator
bd2053b
@cakekoa @mssalvatore
Agent: Remove TargetHost.services
98b43e1
@shreyamalviya @mssalvatore
Agent: Extract PowerShell SSL port in PowerShell auth utils
1f65e8d
@shreyamalviya @mssalvatore
Agent: Rename WebRCE's self.HTTP to self.http_ports
ed0acbc
@shreyamalviya @mssalvatore
Agent: Update some type hints in WebRCE
d9f9410
@shreyamalviya @mssalvatore
Agent: Update WebRCE's docstrings
01600b9
@shreyamalviya @mssalvatore
Agent: Extract PowerShell ports to constants in PowerShellExploiter
c3e11c4
@shreyamalviya @mssalvatore
UT: Extract ports to constants in infection_monkey/exploit/conftest.py
b13e5bd
@shreyamalviya @mssalvatore
Agent: Update type hints in SSHExploiter
7b83885
@ilija-lazoroski @mssalvatore
Hadoop: Fix config schema boolean type
f9c3cea 
Config schemas doesn't have `bool` type
@ilija-lazoroski @mssalvatore
Agent: Rename self.HTTP to self.http_ports in Log4Shell
9074074
@shreyamalviya @mssalvatore
Agent: Fix ports to NetworkPort type and type hints in WebRCE
378e4f3
@shreyamalviya @mssalvatore
Agent: Use pprint.pformat() in TargetHost's __str__()
f6a7b0d
@mssalvatore mssalvatore force-pushed the 2136-replace-targethost-services branch from b4051fa to f6a7b0d Compare February 22, 2023 14:17
@mssalvatore mssalvatore merged commit d5f8d2e into 2136-refactor-scanning Feb 22, 2023
@mssalvatore mssalvatore deleted the 2136-replace-targethost-services branch February 22, 2023 14:18
mssalvatore added a commit that referenced this pull request Feb 22, 2023
@mssalvatore
Merge branch '2136-replace-targethost-services' into 2136-refactor-sc…
a6825ff 
…anning

Issue #2136
PR #2999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski left review comments

@shreyamalviya shreyamalviya shreyamalviya requested changes

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cakekoa @ilija-lazoroski @mssalvatore @shreyamalviya