Skip to content

2136 redefine fingerprinterdata #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 20, 2023
Merged

2136 redefine fingerprinterdata #2987

merged 5 commits into from
Feb 20, 2023

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Feb 17, 2023 •
edited
Loading

What does this PR do?

Fixes part of #2136 .

It needs small manual test. Travis will fail but it will be fixed in next PRs
And it needs unit tests for the pydantic models itself

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

mssalvatore
mssalvatore reviewed Feb 17, 2023
View reviewed changes
@ilija-lazoroski ilija-lazoroski force-pushed the 2136-redefine-fingerprinterdata branch from 0494b0c to 7e06152 Compare February 20, 2023 08:22
@ilija-lazoroski ilija-lazoroski mentioned this pull request Feb 20, 2023
Closed
8 tasks
@shreyamalviya shreyamalviya changed the base branch from 2136-update-TargetHost to 2136-refactor-scanning February 20, 2023 08:30
@ilija-lazoroski ilija-lazoroski force-pushed the 2136-redefine-fingerprinterdata branch from d6b5e48 to 250c676 Compare February 20, 2023 09:51
VakarisZ
VakarisZ reviewed Feb 20, 2023
View reviewed changes
monkey/common/types/networking.py
@@ -32,8 +32,10 @@ class NetworkService(Enum):
"""

HTTP = "http"
HTTPS = "https"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why is this not auto(), but a "member's name in all lower-case characters"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, we need the names of the service to be displayed in the report.

@ilija-lazoroski ilija-lazoroski merged commit c7378d9 into 2136-refactor-scanning Feb 20, 2023
@ilija-lazoroski ilija-lazoroski deleted the 2136-redefine-fingerprinterdata branch February 20, 2023 12:10
mssalvatore pushed a commit that referenced this pull request Feb 22, 2023
@ilija-lazoroski @mssalvatore
Merge pull request #2987 from guardicore/2136-redefine-fingerprinterdata
9bc77b2 
2136 redefine fingerprinterdata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ left review comments

@mssalvatore mssalvatore mssalvatore approved these changes

@shreyamalviya shreyamalviya shreyamalviya approved these changes

@cakekoa cakekoa Awaiting requested review from cakekoa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ilija-lazoroski @mssalvatore @VakarisZ @shreyamalviya @cakekoa