Skip to content

2785 plugins in schema #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 10, 2023
Merged

2785 plugins in schema #2813

merged 11 commits into from
Jan 10, 2023

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Fixes #2785

Does all changes required to switch exploiters in the configuration from Sequence[PluginConfiguration] to Dict[str, Mapping]

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running unit tests, other relevant tests

  • If applicable, add screenshots or log transcripts of the feature working

@VakarisZ VakarisZ force-pushed the 2785-plugins-in-schema branch 2 times, most recently from 95f015c to 6ee287b Compare January 10, 2023 15:04
@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Base: 64.33% // Head: 64.32% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (95f015c) compared to base (708c5a9).
Patch has no changes to coverable lines.

❗ Current head 95f015c differs from pull request most recent head 6ee287b. Consider uploading reports for the commit 6ee287b to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2813      +/-   ##
===========================================
- Coverage    64.33%   64.32%   -0.01%     
===========================================
  Files          408      409       +1     
  Lines        11627    11625       -2     
===========================================
- Hits          7480     7478       -2     
  Misses        4147     4147
Impacted Files Coverage Δ
...ories/utils/agent_configuration_schema_compiler.py 94.87% <0.00%> (-0.26%) ⬇️
monkey/monkey/infection_monkey/master/exploiter.py 95.89% <0.00%> (-0.06%) ⬇️
...monkey/tests/common/example_agent_configuration.py 100.00% <0.00%> (ø)
...agent_configuration/default_agent_configuration.py 100.00% <0.00%> (ø)
...and/cc/repositories/utils/hard_coded_exploiters.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

VakarisZ and others added 11 commits January 10, 2023 11:19
@VakarisZ @mssalvatore
Island: Switch exploiters in schema type to dict
500ae86 
This is done to make the structure of hard-coded exploiters' options to match the options of exploiter plugins
@VakarisZ @mssalvatore
Island: Change schema compiler to merge plugins and exploiters
152e4fb 
Exploiter plugins and hard-coded plugins must be merged to create a cohesive configuration schema
@mssalvatore
UT: Add type hint instead of ignoring mypy error
4ee7a4b
@VakarisZ @mssalvatore
Island: Extend hard coded exploiter schemas
7068426
@VakarisZ @mssalvatore
Island: Change default agent configuration to match new schema
6d607a0
@VakarisZ @mssalvatore
Island: Change report to handle new exploiter config format
aafb3cb
@VakarisZ @mssalvatore
Agent: Change the Agent to use the modified exploiter config
8551a41
@VakarisZ @mssalvatore
Agent, Common: Add comments about exploiter config dict order
0c5598c
@VakarisZ @mssalvatore
Agent: Fix a bug in exploiter.py
72027d1
@VakarisZ @mssalvatore
BB: Change exploiter configurations from list to dict
5e09d7a
@VakarisZ @mssalvatore
CHANGELOG: Add an entry about changed config structure
088c8a0
@mssalvatore mssalvatore force-pushed the 2785-plugins-in-schema branch from 6ee287b to 088c8a0 Compare January 10, 2023 16:20
@mssalvatore mssalvatore merged commit 82a6ce9 into develop Jan 10, 2023
@mssalvatore mssalvatore deleted the 2785-plugins-in-schema branch January 11, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve config schema generation
2 participants
@VakarisZ @mssalvatore