Fix report grammar and support email in UI #2899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
| className='badge badge-info'>{this.state.report.overview.monkey_start_time}</span>. {this.getMonkeyDuration()} | ||
| </p> | ||
| <p> | ||
| The monkey started propagating from the following machines where it was manually installed: | ||
| Infection Monkey started propagating from the following machines where it was manually installed: |
There was a problem hiding this comment.
Shouldn't here be Agent?
| @@ -196,7 +196,7 @@ class ReportPageComponent extends AuthComponent { | |||
| '' | |||
| : | |||
| <p> | |||
| Note: Monkeys were configured to avoid scanning of the local network. | |||
| Note: Infection Monkey was configured to avoid scanning the local network. | |||
There was a problem hiding this comment.
Same question as above.
VakarisZ
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
We should be consistent with how we call the agent. We call it monkey or agent or infection monkey agent or what. Either way, a time will come when we'll have to review the whole UI to make sure it's consistent. @ybasford should help, so don't stress about this now, this has little to do with our goal of releasing plugins ASAP
7f33391 to
44a14fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Minor changes to wording in reports. Updates support email link in report footer.
PR Checklist
Was the documentation framework updated to reflect the changes?Have you checked that you haven't introduced any duplicate code?Testing Checklist
Added relevant unit tests?Have you successfully tested your changes locally? Elaborate:If applicable, add screenshots or log transcripts of the feature working