Skip to content

2578 stub agent plugins endpoint #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2022
Merged

2578 stub agent plugins endpoint #2611

merged 3 commits into from
Nov 22, 2022

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Nov 21, 2022

What does this PR do?

Fixes #2578.

Adds the /api/agent-plugins resource.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited
Loading

Codecov Report

Base: 62.68% // Head: 62.73% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (d2ea9d3) compared to base (a2a588a).
Patch has no changes to coverable lines.

❗ Current head d2ea9d3 differs from pull request most recent head c1b9600. Consider uploading reports for the commit c1b9600 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2611      +/-   ##
===========================================
+ Coverage    62.68%   62.73%   +0.04%     
===========================================
  Files          353      354       +1     
  Lines        10792    10800       +8     
===========================================
+ Hits          6765     6775      +10     
+ Misses        4027     4025       -2
Impacted Files Coverage Δ
...monkey/monkey_island/cc/resources/agent_plugins.py 100.00% <0.00%> (ø)
monkey/monkey/monkey_island/cc/app.py 75.86% <0.00%> (+0.20%) ⬆️
.../monkey/tests/unit_tests/monkey_island/conftest.py 95.65% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mssalvatore
mssalvatore reviewed Nov 22, 2022
View reviewed changes
@shreyamalviya shreyamalviya force-pushed the 2578-stub-agent-plugins-endpoint branch from d2ea9d3 to ec67e4d Compare November 22, 2022 09:19
@ilija-lazoroski ilija-lazoroski force-pushed the 2578-stub-agent-plugins-endpoint branch from ec67e4d to d44b027 Compare November 22, 2022 09:21
@ilija-lazoroski ilija-lazoroski force-pushed the 2578-stub-agent-plugins-endpoint branch from d44b027 to c1b9600 Compare November 22, 2022 09:23
@VakarisZ VakarisZ merged commit f5f5bc6 into develop Nov 22, 2022
@VakarisZ VakarisZ deleted the 2578-stub-agent-plugins-endpoint branch November 22, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

@shreyamalviya shreyamalviya shreyamalviya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create stubbed /api/agent-plugins/<string:type>/<string:name> endpoint
4 participants
@cakekoa @mssalvatore @shreyamalviya @VakarisZ