Skip to content

Remove elastic fingerprinter #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 8, 2022
Merged

Remove elastic fingerprinter #2678

merged 9 commits into from
Dec 8, 2022

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Fixes #2674

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@shreyamalviya shreyamalviya force-pushed the 2674-remove-elastic-fingerprinter branch from f09d5a9 to 6076797 Compare December 8, 2022 12:38
@codecov
Copy link

codecov bot commented Dec 8, 2022 •
edited
Loading

Codecov Report

Base: 63.26% // Head: 63.20% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (6076797) compared to base (99736ce).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2678      +/-   ##
===========================================
- Coverage    63.26%   63.20%   -0.07%     
===========================================
  Files          377      375       -2     
  Lines        11184    11149      -35     
===========================================
- Hits          7076     7047      -29     
+ Misses        4108     4102       -6
Impacted Files Coverage Δ
monkey/monkey/infection_monkey/monkey.py 0.00% <0.00%> (ø)
...agent_configuration/default_agent_configuration.py 100.00% <0.00%> (ø)
...ey/network_scanning/elasticsearch_fingerprinter.py
...nkey/monkey/common/common_consts/network_consts.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mssalvatore
mssalvatore reviewed Dec 8, 2022
View reviewed changes
monkey/common/agent_configuration/default_agent_configuration.py
9600,
)

TCP_SCAN_CONFIGURATION = TCPScanConfiguration(timeout=3.0, ports=TCP_PORTS)
ICMP_CONFIGURATION = ICMPScanConfiguration(timeout=1.0)
HTTP_PORTS = (80, 443, 7001, 8008, 8080, 8983, 9200, 9600)
HTTP_PORTS = (80, 443, 7001, 8008, 8080, 8983, 9600)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any blackbox tests need to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, nothing uses it

@mssalvatore mssalvatore force-pushed the 2674-remove-elastic-fingerprinter branch from 6076797 to a26a7a0 Compare December 8, 2022 15:06
@mssalvatore mssalvatore merged commit e9ba57b into develop Dec 8, 2022
@mssalvatore mssalvatore deleted the 2674-remove-elastic-fingerprinter branch December 8, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Elasticsearch fingerprinter
2 participants
@shreyamalviya @mssalvatore