2267 remove scan telemetry #2428
Conversation
| return [NodeService.monkey_to_net_node(x) for x in mongo.db.monkey.find({})] | ||
| return legacy_agents + legacy_nodes + monkey_island | ||
|
|
||
| def _get_monkey_net_nodes(self): |
There was a problem hiding this comment.
Removing scan telemetries broke the map, because the OS version relied on it. I think a good way of refactoring map are these steps:
- Gradually replace the data gathered for display nodes/edges from legacy documents with the data gathered from events.
- Once all data for map display relies only on events, migrate the logic to the front end.
This gives us 2 advantages over just breaking the map and fixing it in one issue: 1. develop is always in a working state 2. When we migrate the logic to the front end the scope of it is clear (we just need to re-write python to javascript)
There was a problem hiding this comment.
We're rewriting the map this week anyway.
Scan results are now events with a different structure
Codecov ReportBase: 61.10% // Head: 61.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2428 +/- ##
===========================================
+ Coverage 61.10% 61.12% +0.02%
===========================================
Files 559 556 -3
Lines 14844 14733 -111
===========================================
- Hits 9070 9006 -64
+ Misses 5774 5727 -47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What does this PR do?
Fixes #2267
Scan telemetry got deprecated by scan events
PR Checklist
Testing Checklist