Island, Agent: Move local IP and interface retrieval to common #2298
Conversation
Codecov ReportBase: 59.37% // Head: 59.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2298 +/- ##
===========================================
+ Coverage 59.37% 59.49% +0.11%
===========================================
Files 531 532 +1
Lines 13765 13766 +1
===========================================
+ Hits 8173 8190 +17
+ Misses 5592 5576 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
46d34f6 to
930a0c7
Compare
There was a problem hiding this comment.
None of these functions should have local in the name. If interfaces have public IPs (not local network IPs), the function will return them. Furthermore, the functions filter out the loopback interface, which is traditionally considered a local interface.
Use get_network_interfaces()
|
I'm not sure what's a better name to indicate that we are getting ip's of the current/local machine (not victim host or anything). |
What about |
Both, island and agent needs to get local IP's/interfaces. We should also consider merging them, since interfaces also contain IP's
12a218e to
2474416
Compare
Both, island and agent needs to get local IP's/interfaces. We should also consider merging them, since interfaces also contain IP's
What does this PR do?
Fixes #2216
Add any further explanations here.
PR Checklist
Testing Checklist