Skip to content

2155 events endpoint #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2022
Merged

2155 events endpoint #2187

merged 3 commits into from
Aug 11, 2022

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Aug 11, 2022 •
edited
Loading

What does this PR do?

Fixes #2155.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

image

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #2187 (933bc0c) into develop (5558d07) will increase coverage by 0.01%.
The diff coverage is 76.92%.

@@             Coverage Diff             @@
##           develop    #2187      +/-   ##
===========================================
+ Coverage    56.96%   56.98%   +0.01%     
===========================================
  Files          498      499       +1     
  Lines        13379    13392      +13     
===========================================
+ Hits          7622     7632      +10     
- Misses        5757     5760       +3
Impacted Files Coverage Δ
monkey/monkey_island/cc/resources/events.py 72.72% <72.72%> (ø)
monkey/monkey_island/cc/app.py 79.72% <100.00%> (+0.14%) ⬆️
monkey/monkey_island/cc/resources/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mssalvatore mssalvatore merged commit 956621d into develop Aug 11, 2022
@mssalvatore mssalvatore deleted the 2155-events-endpoint branch August 11, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create dummy /api/events endpoint
2 participants
@ilija-lazoroski @mssalvatore