Skip to content

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Fixes #2105

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #2150 (c7f9a5c) into develop (4801235) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2150   +/-   ##
========================================
  Coverage    56.94%   56.94%           
========================================
  Files          489      489           
  Lines        13282    13282           
========================================
  Hits          7563     7563           
  Misses        5719     5719           
Impacted Files Coverage Δ
...ey/monkey_island/cc/resources/auth/authenticate.py 92.00% <ø> (ø)
...onkey_island/cc/services/authentication_service.py 100.00% <ø> (ø)
monkey/monkey_island/cc/app.py 80.53% <100.00%> (ø)
monkey/monkey_island/cc/resources/auth/register.py 100.00% <100.00%> (ø)
monkey/monkey_island/cc/server_utils/file_utils.py 57.14% <0.00%> (-1.95%) ⬇️
...key/monkey_island/cc/server_utils/island_logger.py 100.00% <0.00%> (+7.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4801235...c7f9a5c. Read the comment docs.

@@ -12,13 +12,24 @@


class Registration(AbstractResource):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been renamed Register in #2147

@shreyamalviya shreyamalviya merged commit ad5ff9a into develop Aug 2, 2022
@shreyamalviya shreyamalviya deleted the 2105-add-docstrings branch August 2, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor authentication endpoints
2 participants