Skip to content

Rename endpoints for auth and register, remove unnecessary error #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 2, 2022
Merged

Rename endpoints for auth and register, remove unnecessary error #2147

merged 14 commits into from
Aug 2, 2022

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Aug 2, 2022 •
edited
Loading

What does this PR do?

Fixes two tasks of #2105

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running locally

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Aug 2, 2022 •
edited
Loading

Codecov Report

Merging #2147 (486e289) into develop (3016688) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2147   +/-   ##
========================================
  Coverage    56.91%   56.91%           
========================================
  Files          488      488           
  Lines        13274    13274           
========================================
  Hits          7555     7555           
  Misses        5719     5719
Impacted Files Coverage Δ
monkey/monkey_island/cc/app.py 80.27% <100.00%> (ø)
...ey/monkey_island/cc/resources/auth/authenticate.py 92.00% <100.00%> (ø)
monkey/monkey_island/cc/resources/auth/register.py 100.00% <100.00%> (ø)
.../unit_tests/monkey_island/cc/resources/conftest.py 84.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3016688...486e289. Read the comment docs.

@shreyamalviya shreyamalviya changed the title Rename endpoints for auth and register Rename endpoints for auth and register, remove unnecessary error Aug 2, 2022
@shreyamalviya shreyamalviya merged commit 9442b66 into develop Aug 2, 2022
@shreyamalviya shreyamalviya deleted the 2105-refactor-auth-endpoints branch August 2, 2022 08:45
@mssalvatore mssalvatore mentioned this pull request Aug 2, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyamalviya @VakarisZ