Skip to content

2106 remove mode keyword #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 3, 2022
Merged

2106 remove mode keyword #2145

merged 9 commits into from
Aug 3, 2022

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Fixes #2106.

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Aug 1, 2022 •
edited
Loading

Codecov Report

Merging #2145 (5a06e88) into develop (dd882df) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2145      +/-   ##
===========================================
- Coverage    56.89%   56.87%   -0.02%     
===========================================
  Files          489      491       +2     
  Lines        13279    13293      +14     
===========================================
+ Hits          7555     7561       +6     
- Misses        5724     5732       +8
Impacted Files Coverage Δ
monkey/monkey_island/cc/resources/island_mode.py 96.00% <100.00%> (-4.00%) ⬇️
monkey/monkey_island/cc/server_utils/file_utils.py 57.14% <0.00%> (-1.95%) ⬇️
monkey/monkey_island/cc/resources/__init__.py 100.00% <0.00%> (ø)
monkey/monkey_island/cc/services/initialize.py 0.00% <0.00%> (ø)
...key/monkey_island/cc/server_utils/island_logger.py 100.00% <0.00%> (ø)
...onkey_island/cc/services/authentication_service.py 100.00% <0.00%> (ø)
monkey/monkey_island/cc/resources/auth/auth.py
monkey/monkey_island/cc/services/island_logs.py
monkey/monkey_island/cc/resources/island_logs.py
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd882df...5a06e88. Read the comment docs.

mssalvatore
mssalvatore reviewed Aug 1, 2022
View reviewed changes
shreyamalviya
shreyamalviya reviewed Aug 2, 2022
View reviewed changes
@shreyamalviya shreyamalviya force-pushed the 2106-remove-mode-keyword branch from d27a95f to 7b57842 Compare August 3, 2022 08:41
@shreyamalviya shreyamalviya force-pushed the 2106-remove-mode-keyword branch from 7b57842 to 4bcab89 Compare August 3, 2022 09:57
mssalvatore
mssalvatore reviewed Aug 3, 2022
View reviewed changes
@mssalvatore mssalvatore merged commit 17b264d into develop Aug 3, 2022
@mssalvatore mssalvatore deleted the 2106-remove-mode-keyword branch August 3, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyamalviya shreyamalviya shreyamalviya left review comments

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor /api/island-mode
3 participants
@ilija-lazoroski @mssalvatore @shreyamalviya