Skip to content

2106 refactor island mode #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 1, 2022
Merged

2106 refactor island mode #2143

merged 7 commits into from
Aug 1, 2022

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Aug 1, 2022 •
edited
Loading

What does this PR do?

Fixes #2106 .

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@ilija-lazoroski ilija-lazoroski force-pushed the 2106-refactor-island-mode branch from 73aeb35 to 9075f01 Compare August 1, 2022 12:23
@codecov
Copy link

codecov bot commented Aug 1, 2022 •
edited
Loading

Codecov Report

Merging #2143 (8e62bef) into develop (759de2a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8e62bef differs from pull request most recent head f19d489. Consider uploading reports for the commit f19d489 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2143   +/-   ##
========================================
  Coverage    56.69%   56.69%           
========================================
  Files          486      486           
  Lines        13218    13219    +1     
========================================
+ Hits          7494     7495    +1     
  Misses        5724     5724
Impacted Files Coverage Δ
monkey/monkey_island/cc/resources/island_mode.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 759de2a...f19d489. Read the comment docs.

mssalvatore
mssalvatore requested changes Aug 1, 2022
View reviewed changes
@mssalvatore mssalvatore merged commit dd882df into develop Aug 1, 2022
@mssalvatore mssalvatore deleted the 2106-refactor-island-mode branch August 1, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

@shreyamalviya shreyamalviya Awaiting requested review from shreyamalviya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor /api/island-mode
2 participants
@ilija-lazoroski @mssalvatore