Skip to content

Rename credential_collector_classes #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 10, 2022
Merged

Rename credential_collector_classes #2009

merged 4 commits into from
Jun 10, 2022

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Fixes #1997

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the Island and checking that the config page doesn't crash

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Jun 9, 2022 •
edited
Loading

Codecov Report

Merging #2009 (1cef787) into develop (8d4e517) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2009   +/-   ##
========================================
  Coverage    56.53%   56.54%           
========================================
  Files          465      465           
  Lines        12991    12992    +1     
========================================
+ Hits          7345     7346    +1     
  Misses        5646     5646
Impacted Files Coverage Δ
monkey/infection_monkey/master/automated_master.py 82.60% <ø> (ø)
..._island/cc/services/config_schema/config_schema.py 100.00% <ø> (ø)
.../monkey_island/cc/services/config_schema/monkey.py 100.00% <ø> (ø)
...schema/definitions/credential_collector_classes.py 100.00% <100.00%> (ø)
monkey/monkey_island/cc/services/config.py 86.64% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d4e517...1cef787. Read the comment docs.

@VakarisZ VakarisZ force-pushed the 1997-rename-credential_collector_classes branch from 5d74d1f to 1cef787 Compare June 10, 2022 07:25
@VakarisZ VakarisZ merged commit eb7e74c into develop Jun 10, 2022
@VakarisZ VakarisZ deleted the 1997-rename-credential_collector_classes branch June 10, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename credential_collector_classes to credential_collectors
2 participants
@shreyamalviya @VakarisZ