Skip to content

Remove unused AWS config fields #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 10, 2022
Merged

Remove unused AWS config fields #2008

merged 4 commits into from
Jun 10, 2022

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Jun 9, 2022 •
edited
Loading

What does this PR do?

Fixes #1994

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2008 (61e3d71) into develop (8d4e517) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2008      +/-   ##
===========================================
- Coverage    56.53%   56.52%   -0.02%     
===========================================
  Files          465      465              
  Lines        12991    12990       -1     
===========================================
- Hits          7345     7343       -2     
- Misses        5646     5647       +1
Impacted Files Coverage Δ
monkey/common/config_value_paths.py 100.00% <ø> (ø)
monkey/infection_monkey/config.py 34.00% <ø> (ø)
monkey/monkey_island/cc/services/config.py 86.29% <ø> (-0.32%) ⬇️
...onkey_island/cc/services/config_schema/internal.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d4e517...61e3d71. Read the comment docs.

@VakarisZ VakarisZ merged commit 1f4f573 into develop Jun 10, 2022
@VakarisZ VakarisZ deleted the 1994-remove-unused-aws-config-options branch June 10, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused AWS configuration options
2 participants
@shreyamalviya @VakarisZ