Skip to content

Island: Refactor agent-binaries resource #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2022
Merged

Island: Refactor agent-binaries resource #2005

merged 4 commits into from
Jun 9, 2022

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Jun 9, 2022 •
edited
Loading

What does this PR do?

Fixes #1974

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running locally and exploiting a machine

  • If applicable, add screenshots or log transcripts of the feature working

image

image

@codecov
Copy link

codecov bot commented Jun 9, 2022 •
edited
Loading

Codecov Report

Merging #2005 (2415ddc) into develop (b8c4ae8) will increase coverage by 0.03%.
The diff coverage is 37.96%.

@@             Coverage Diff             @@
##           develop    #2005      +/-   ##
===========================================
+ Coverage    56.50%   56.53%   +0.03%     
===========================================
  Files          463      465       +2     
  Lines        12985    12991       +6     
===========================================
+ Hits          7337     7345       +8     
+ Misses        5648     5646       -2
Impacted Files Coverage Δ
...tory/file_storage/local_storage_file_repository.py 97.77% <ø> (-0.05%) ⬇️
monkey/monkey_island/cc/server_setup.py 0.00% <ø> (ø)
monkey/monkey_island/cc/services/initialize.py 0.00% <0.00%> (ø)
...onkey/monkey_island/cc/resources/agent_binaries.py 42.85% <20.00%> (+3.83%) ⬆️
...nkey/monkey_island/cc/services/run_local_monkey.py 30.43% <24.00%> (-11.68%) ⬇️
monkey/monkey_island/cc/resources/local_run.py 52.17% <33.33%> (-0.21%) ⬇️
...ey_island/cc/repository/agent_binary_repository.py 52.94% <52.94%> (ø)
monkey/common/utils/file_utils.py 100.00% <100.00%> (ø)
monkey/monkey_island/cc/app.py 80.13% <100.00%> (-0.14%) ⬇️
monkey/monkey_island/cc/repository/__init__.py 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee38c31...2415ddc. Read the comment docs.

@ilija-lazoroski ilija-lazoroski marked this pull request as ready for review June 9, 2022 11:26
mssalvatore
mssalvatore requested changes Jun 9, 2022
View reviewed changes
@ilija-lazoroski
Island: Refactor agent-binaries resource
7da3640
@ilija-lazoroski
UI: Remove dropper config schema key
152b486 
Dropper configurations are removed entirely.
@ilija-lazoroski
Island: Fix small docstrings
0b15294
@ilija-lazoroski
Island: Refactor LocalMonkerRunService to use AgentBinaryRepository
2415ddc 
* Register the data_dir in the DI container
* Construct LocalRun resource with the LocalMonkeyRunService
@ilija-lazoroski ilija-lazoroski force-pushed the 1974-refactor-agent-binaries-resource branch from 31c4831 to 2415ddc Compare June 9, 2022 17:18
@ilija-lazoroski ilija-lazoroski merged commit ae2d212 into develop Jun 9, 2022
@ilija-lazoroski ilija-lazoroski deleted the 1974-refactor-agent-binaries-resource branch June 9, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor MonkeyDownload resource
2 participants
@ilija-lazoroski @mssalvatore