957 island reset improvements #1909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collection name properties are useful for queries related to these specific collections
This endpoint allows to delete the data gathered by agents without resetting config related databases
New modal allows to save clicks, explains the situation better, offers to export the config and allows deleting agent data without deleting config
Codecov Report
@@ Coverage Diff @@
## develop #1909 +/- ##
===========================================
- Coverage 54.90% 54.52% -0.39%
===========================================
Files 446 446
Lines 12637 12848 +211
===========================================
+ Hits 6938 7005 +67
- Misses 5699 5843 +144
Continue to review full report at Codecov.
|
mssalvatore
approved these changes
Apr 21, 2022
| To exit a scenario and select another one, click on "Start Over". | ||
|
|
||
| To exit a scenario and select another one, click on "Reset". | ||
| <!--- TODO fix the screenshot ---> |
There was a problem hiding this comment.
Can we just fix it instead of leaving a TODO?
There was a problem hiding this comment.
Yes, I left this here because I knew I'll forget this :D
| !props.allMonkeysAreDead ? | ||
| <div className='alert alert-warning'> | ||
| <FontAwesomeIcon icon={faExclamationTriangle} style={{'marginRight': '5px'}}/> | ||
| Can't reset the Island while Monkey agents are still running! |
There was a problem hiding this comment.
Suggested change
| Can't reset the Island while Monkey agents are still running! | |
| Please stop all running agents before attempting to reset the Island. |
ilija-lazoroski
approved these changes
Apr 21, 2022
This change makes the warning more actionable
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #957
Add any further explanations here.
PR Checklist
Testing Checklist