Skip to content

Agent: Change windows removal command #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 20, 2022
Merged

Agent: Change windows removal command #1900

merged 6 commits into from
Apr 20, 2022

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Apr 20, 2022 •
edited
Loading

What does this PR do?

Fixes #1763

Couple issues, first was that we had infinite loop where we waited to deleted the executable and second
monkey name with spaces like 'monkey-windows-64 - Copy.exe' was not deleted because the spaces.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running locally and running the Hadoop BB test

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

Are the commit messages enough? If not, elaborate.

@codecov
Copy link

codecov bot commented Apr 20, 2022 •
edited
Loading

Codecov Report

Merging #1900 (53d1c55) into develop (4f5711b) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1900      +/-   ##
===========================================
- Coverage    54.94%   54.86%   -0.08%     
===========================================
  Files          446      446              
  Lines        12626    12641      +15     
===========================================
- Hits          6937     6936       -1     
- Misses        5689     5705      +16
Impacted Files Coverage Δ
monkey/infection_monkey/model/__init__.py 100.00% <ø> (ø)
monkey/infection_monkey/monkey.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5711b...53d1c55. Read the comment docs.

VakarisZ
VakarisZ reviewed Apr 20, 2022
View reviewed changes
@ilija-lazoroski ilija-lazoroski force-pushed the 1763-fix-windows-exe-removal branch from bf2f5b6 to 0b3d3cf Compare April 20, 2022 10:35
@ilija-lazoroski ilija-lazoroski force-pushed the 1763-fix-windows-exe-removal branch from 0b3d3cf to ed90d6f Compare April 20, 2022 11:21
mssalvatore
mssalvatore reviewed Apr 20, 2022
View reviewed changes
@ilija-lazoroski ilija-lazoroski force-pushed the 1763-fix-windows-exe-removal branch from f7d5c18 to a2358a7 Compare April 20, 2022 11:49
mssalvatore
mssalvatore reviewed Apr 20, 2022
View reviewed changes
@ilija-lazoroski ilija-lazoroski force-pushed the 1763-fix-windows-exe-removal branch from e545473 to a7f6953 Compare April 20, 2022 12:27
mssalvatore
mssalvatore reviewed Apr 20, 2022
View reviewed changes
mssalvatore
mssalvatore reviewed Apr 20, 2022
View reviewed changes
@ilija-lazoroski ilija-lazoroski force-pushed the 1763-fix-windows-exe-removal branch 2 times, most recently from da92192 to 102bca0 Compare April 20, 2022 14:33
@mssalvatore mssalvatore force-pushed the 1763-fix-windows-exe-removal branch from edc3da3 to 53d1c55 Compare April 20, 2022 16:27
@ilija-lazoroski ilija-lazoroski merged commit 2eb47ef into develop Apr 20, 2022
@ilija-lazoroski ilija-lazoroski deleted the 1763-fix-windows-exe-removal branch April 20, 2022 18:51
@mssalvatore mssalvatore restored the 1763-fix-windows-exe-removal branch April 20, 2022 19:01
mssalvatore added a commit that referenced this pull request Apr 20, 2022
@mssalvatore
Merge pull request #1900 from guardicore/1763-fix-windows-exe-removal
d1ac07b
@mssalvatore mssalvatore deleted the 1763-fix-windows-exe-removal branch April 20, 2022 19:12
@ilija-lazoroski ilija-lazoroski mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

@shreyamalviya shreyamalviya Awaiting requested review from shreyamalviya

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows agent is not deleted after completition
3 participants
@ilija-lazoroski @mssalvatore @VakarisZ