Skip to content

Add page about agent propagation to docs #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2022
Merged

Add page about agent propagation to docs #1981

merged 4 commits into from
Jun 9, 2022

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Fixes #1961

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running Hugo

  • If applicable, add screenshots or log transcripts of the feature working

image

@codecov
Copy link

codecov bot commented Jun 3, 2022 •
edited
Loading

Codecov Report

Merging #1981 (f0fbafc) into develop (09958c2) will increase coverage by 0.03%.
The diff coverage is 54.05%.

@@             Coverage Diff             @@
##           develop    #1981      +/-   ##
===========================================
+ Coverage    56.50%   56.53%   +0.03%     
===========================================
  Files          463      465       +2     
  Lines        12986    12991       +5     
===========================================
+ Hits          7338     7345       +7     
+ Misses        5648     5646       -2
Impacted Files Coverage Δ
monkey/infection_monkey/config.py 34.00% <ø> (-1.30%) ⬇️
monkey/infection_monkey/dropper.py 0.00% <0.00%> (ø)
monkey/infection_monkey/main.py 0.00% <0.00%> (ø)
monkey/infection_monkey/monkey.py 0.00% <0.00%> (ø)
.../monkey_island/cc/repository/i_agent_repository.py 0.00% <ø> (ø)
...monkey_island/cc/repository/i_attack_repository.py 0.00% <ø> (ø)
...monkey_island/cc/repository/i_config_repository.py 0.00% <ø> (ø)
...ey/monkey_island/cc/repository/i_log_repository.py 0.00% <ø> (ø)
...onkey_island/cc/repository/i_machine_repository.py 0.00% <ø> (ø)
...y_island/cc/repository/i_network_map_repository.py 0.00% <ø> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 594d215...f0fbafc. Read the comment docs.

mssalvatore
mssalvatore requested changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should provide some information about how the dropper is sometimes used. If we don't already have that somewhere in the documentation, we'll need to write it. If we do, we can link to it.

@VakarisZ VakarisZ requested a review from mssalvatore June 9, 2022 14:56
@mssalvatore mssalvatore merged commit 542c426 into develop Jun 9, 2022
@mssalvatore mssalvatore deleted the 1961-docs-agent-propagation branch June 9, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

@mssalvatore mssalvatore Awaiting requested review from mssalvatore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decouple the dropper and the WormConfiguration
4 participants
@shreyamalviya @ilija-lazoroski @mssalvatore @VakarisZ