Skip to content

Change AgentBinaries URL #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 3, 2022
Merged

Change AgentBinaries URL #1978

merged 6 commits into from
Jun 3, 2022

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Jun 2, 2022 •
edited
Loading

What does this PR do?

Fixes a part of #1974

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by testing the endpoint manually on Windows.

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Jun 2, 2022 •
edited
Loading

Codecov Report

Merging #1978 (c43bc3a) into develop (09958c2) will decrease coverage by 0.00%.
The diff coverage is 55.31%.

@@             Coverage Diff             @@
##           develop    #1978      +/-   ##
===========================================
- Coverage    56.50%   56.50%   -0.01%     
===========================================
  Files          463      463              
  Lines        12986    12985       -1     
===========================================
- Hits          7338     7337       -1     
  Misses        5648     5648
Impacted Files Coverage Δ
monkey/infection_monkey/config.py 34.00% <ø> (-1.30%) ⬇️
monkey/infection_monkey/dropper.py 0.00% <0.00%> (ø)
...fection_monkey/exploit/caching_agent_repository.py 60.00% <ø> (ø)
monkey/infection_monkey/main.py 0.00% <0.00%> (ø)
monkey/infection_monkey/monkey.py 0.00% <0.00%> (ø)
.../monkey_island/cc/repository/i_agent_repository.py 0.00% <ø> (ø)
...monkey_island/cc/repository/i_attack_repository.py 0.00% <ø> (ø)
...monkey_island/cc/repository/i_config_repository.py 0.00% <ø> (ø)
...ey/monkey_island/cc/repository/i_log_repository.py 0.00% <ø> (ø)
...onkey_island/cc/repository/i_machine_repository.py 0.00% <ø> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 594d215...c43bc3a. Read the comment docs.

mssalvatore
mssalvatore reviewed Jun 2, 2022
View reviewed changes
@shreyamalviya shreyamalviya requested a review from mssalvatore June 3, 2022 07:36
@shreyamalviya @mssalvatore
Island: Change AgentBinaries URL parameter name
c43bc3a 
Co-authored-by: Mike Salvatore <mike.s.salvatore@gmail.com>
@shreyamalviya shreyamalviya force-pushed the 1974-change-AgentBinaries-url branch from 0754b63 to c43bc3a Compare June 3, 2022 07:41
VakarisZ
VakarisZ reviewed Jun 3, 2022
View reviewed changes
CHANGELOG.md
@@ -34,6 +34,8 @@ Changelog](https://keepachangelog.com/en/1.0.0/).
- All "/api/monkey_control" endpoints to "/api/monkey-control". #1888
- All "/api/monkey" endpoints to "/api/agent". #1888
- Update MongoDB version to 4.4.x. #1924
- Endpoint to get agent binaries from "/api/agent/download/<string:os>" to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is relevant to the users

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides being an API endpoint which seems relevant enough to me, it is encountered by the user if they try to run the monkey manually using the command given in the UI. I feel like it is.

Copy link
Collaborator

@mssalvatore mssalvatore Jun 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for any user-facing interface belong in the changelog. The HTTP API qualifies.

VakarisZ
VakarisZ approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

@shreyamalviya shreyamalviya merged commit cdbe929 into develop Jun 3, 2022
@shreyamalviya shreyamalviya deleted the 1974-change-AgentBinaries-url branch June 3, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

@mssalvatore mssalvatore Awaiting requested review from mssalvatore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreyamalviya @mssalvatore @VakarisZ