Skip to content

Agent: Remove --config argument #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2022
Merged

Agent: Remove --config argument #1970

merged 2 commits into from
May 30, 2022

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented May 30, 2022 •
edited
Loading

What does this PR do?

Fixes #906 .

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the Agent from source

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

Are the commit messages enough? If not, elaborate.

@ilija-lazoroski ilija-lazoroski force-pushed the 906-remove-config-arg branch from ae4e578 to 8d225b5 Compare May 30, 2022 11:31
@codecov
Copy link

codecov bot commented May 30, 2022 •
edited
Loading

Codecov Report

Merging #1970 (7310cc0) into develop (1bfffb0) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1970      +/-   ##
===========================================
+ Coverage    56.44%   56.51%   +0.06%     
===========================================
  Files          461      461              
  Lines        13006    12985      -21     
===========================================
- Hits          7341     7338       -3     
+ Misses        5665     5647      -18
Impacted Files Coverage Δ
monkey/infection_monkey/config.py 38.88% <ø> (-3.22%) ⬇️
monkey/infection_monkey/dropper.py 0.00% <0.00%> (ø)
monkey/infection_monkey/main.py 0.00% <0.00%> (ø)
monkey/infection_monkey/monkey.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3710e4...7310cc0. Read the comment docs.

@VakarisZ VakarisZ force-pushed the 906-remove-config-arg branch from 23d51c5 to 7310cc0 Compare May 30, 2022 13:04
@VakarisZ VakarisZ merged commit 6221a43 into develop May 30, 2022
@VakarisZ VakarisZ deleted the 906-remove-config-arg branch May 30, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore Awaiting requested review from mssalvatore

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for manually uploaded config.
2 participants
@ilija-lazoroski @VakarisZ