1695 parsing mimikatz #1731
Merged
1695 parsing mimikatz #1731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Leftover from broken info gathering package
No system info telemetries need to be processed anymore
b9cbfde to
40fe08b
Compare
Island: rename credentials_type.py
40fe08b to
8c90a98
Compare
mssalvatore
approved these changes
Feb 22, 2022
Comment on lines
+27
to
+29
| IDENTITY_PROCESSORS[identity["credential_type"]](identity) | ||
| for secret in credential["secrets"]: | ||
| SECRET_PROCESSORS[secret["credential_type"]](secret) |
There was a problem hiding this comment.
Since we don't make any distinction between secrets and identities in CredentialComponentType, I'm not sure if there's value in making that distinction here. Similarly, I'm not sure we need to separate the processors into identities/ and secrets/ directories.
Comment on lines
+16
to
22
| TelemCategoryEnum.CREDENTIALS: parse_credentials, | ||
| TelemCategoryEnum.TUNNEL: process_tunnel_telemetry, | ||
| TelemCategoryEnum.STATE: process_state_telemetry, | ||
| TelemCategoryEnum.EXPLOIT: process_exploit_telemetry, | ||
| TelemCategoryEnum.SCAN: process_scan_telemetry, | ||
| TelemCategoryEnum.SYSTEM_INFO: process_system_info_telemetry, | ||
| TelemCategoryEnum.POST_BREACH: process_post_breach_telemetry, | ||
| TelemCategoryEnum.AWS_INFO: process_aws_telemetry, |
There was a problem hiding this comment.
While we're here, can we put these in alphabetical order as per the boy scout rule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #1695.
Add any further explanations here.
PR Checklist
Testing Checklist
Explain Changes
Are the commit messages enough? If not, elaborate.