Elastic with framework #162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 19, 2018 12:33
…read to stop. We can run our program while the thread stops
…h) and server lock is not a singleton anymore
added 15 commits
August 9, 2018 12:13
…in network/tools no message
…t always have permissions to uppload to C:\Windows)
… into class methods)
715daf8 to
47160c1
Compare
| @@ -34,197 +35,68 @@ class ElasticGroovyExploiter(HostExploiter): | |||
|
|
|||
| DOWNLOAD_TIMEOUT = 300 # copied from rdpgrinder | |||
|
|
|||
| # Both commands are prepared for use in future development | |||
There was a problem hiding this comment.
remove these commands and use the ones on model_init_.py
| return False | ||
| # Extra escaping required: | ||
| config = copy.deepcopy(self._config) | ||
| config.dropper_target_path_win_32 = r"C:\\\\Windows\\\\monkey32.exe" |
There was a problem hiding this comment.
This is not good for 2 reasons:
- your point was to just escape everything, so just do it (replace '' with '\'). That way if the target path actually changes, we won't have to change it in here as well.
- you're deep copying the entire config just for escaping 2 values for a temporary use. Find another way to do this. Consider changing check_remote_files' parameters.
|
|
||
| def exploit_host(self): | ||
| # self.exploit_host_linux() |
There was a problem hiding this comment.
commented out code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature / Fixes