Skip to content

1535 hostname collector removal #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 19, 2021
Merged

1535 hostname collector removal #1617

merged 8 commits into from
Nov 19, 2021

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Fixes #1535
Removes hostname collector

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running monkey manually on island and on another machine

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

Hostname collector not needed, because hostname is always collected in infection_monkey\monkey\infection_monkey\control.py:48

ilija-lazoroski
ilija-lazoroski requested changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missed spot in: docs/content/development/adding-system-info-collectors.py , envs/monkey_zoo/blackbox/config_template/base_template.py , envs/monkey_zoo/blackbox/config_template/smb_mimikatz.py , envs/monkey_zoo/blackbox/config_template/wmi_mimikatz.py

@codecov
Copy link

codecov bot commented Nov 17, 2021 •
edited
Loading

Codecov Report

Merging #1617 (216af63) into develop (c0f4435) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1617      +/-   ##
===========================================
- Coverage    44.65%   44.64%   -0.01%     
===========================================
  Files          468      466       -2     
  Lines        13628    13606      -22     
===========================================
- Hits          6086     6075      -11     
+ Misses        7542     7531      -11
Impacted Files Coverage Δ
...mmon/common_consts/system_info_collectors_names.py 100.00% <ø> (ø)
...chema/definitions/system_info_collector_classes.py 100.00% <ø> (ø)
.../monkey_island/cc/services/config_schema/monkey.py 100.00% <ø> (ø)
monkey/monkey_island/cc/models/monkey.py 90.36% <100.00%> (-0.55%) ⬇️
...nfo_collectors/system_info_telemetry_dispatcher.py 88.88% <100.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f4435...216af63. Read the comment docs.

@mssalvatore mssalvatore merged commit ee285b6 into develop Nov 19, 2021
@mssalvatore mssalvatore deleted the 1535-hostname-collector-removal branch November 19, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski requested changes

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused system info collectors
3 participants
@VakarisZ @ilija-lazoroski @mssalvatore