Skip to content

Agent: Remove sambacry binaries from monkey spec #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

Agent: Remove sambacry binaries from monkey spec #1698

merged 1 commit into from
Feb 4, 2022

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Feb 4, 2022 •
edited
Loading

What does this PR do?

Fixes #1693 .

Some remains referencing sambacry binaries.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

image
image

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #1698 (4bf04da) into develop (81bc579) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1698   +/-   ##
========================================
  Coverage    45.56%   45.56%           
========================================
  Files          470      470           
  Lines        13760    13760           
========================================
  Hits          6270     6270           
  Misses        7490     7490

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81bc579...4bf04da. Read the comment docs.

@mssalvatore mssalvatore force-pushed the 1693-remove-sambacry-remains branch from 4bf04da to b89f9c3 Compare February 4, 2022 18:24
@mssalvatore mssalvatore merged commit 88d4e9b into develop Feb 4, 2022
@mssalvatore mssalvatore deleted the 1693-remove-sambacry-remains branch February 4, 2022 18:25
mssalvatore
mssalvatore reviewed Feb 4, 2022
View reviewed changes
Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

mssalvatore pushed a commit that referenced this pull request Feb 9, 2022
@ilija-lazoroski @mssalvatore
Agent: Remove sambacry binaries from monkey spec
fb8847b 
PR #1698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove lingering references to sambacry binaries
2 participants
@ilija-lazoroski @mssalvatore