Update T1086 (PowerShell) reporting to include PBA results #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…A in T1086's report
ilija-lazoroski
approved these changes
Oct 12, 2021
VakarisZ
reviewed
Oct 12, 2021
Comment on lines
43
to
45
| "$or": [ | ||
| {"data.command": {"$regex": r"\.ps1"}}, | ||
| {"data.result": {"$regex": r"\.ps1"}}, |
There was a problem hiding this comment.
Account discovery uses PowerShell but will not get found by this query
VakarisZ
reviewed
Oct 12, 2021
| return ([{ | ||
| Header: 'Example Powershell commands used', | ||
| Header: 'PowerShell commands used on exploited machines', |
There was a problem hiding this comment.
PBA's are also powershell commands used on exploited machines
VakarisZ
reviewed
Oct 12, 2021
| @@ -32,18 +32,72 @@ class T1086 extends React.Component { | |||
| }]) | |||
| } | |||
|
|
|||
| static getPowershellColumnsForPBAs() { | |||
| return ([{ | |||
| Header: 'PBAs that used PowerShell commands or scripts', | |||
There was a problem hiding this comment.
Maybe the header could be simply "Post Breach Actions", because that's what user sees in the configuration
VakarisZ
requested changes
Oct 12, 2021
98ce106 to
82eea6a
Compare
VakarisZ
reviewed
Oct 13, 2021
| @@ -12,7 +12,7 @@ class T1086 extends React.Component { | |||
|
|
|||
| static getPowershellColumnsForExploits() { | |||
| return ([{ | |||
| Header: 'PowerShell commands used on exploited machines', | |||
| Header: 'PowerShell commands used during exploitation', | |||
There was a problem hiding this comment.
I'd further simplify this to "Exploiters" because there's already a section explaining that Monkey used PowerShell commands.
VakarisZ
reviewed
Oct 13, 2021
| @@ -34,7 +34,7 @@ class T1086 extends React.Component { | |||
|
|
|||
| static getPowershellColumnsForPBAs() { | |||
| return ([{ | |||
| Header: 'PBAs that used PowerShell commands or scripts', | |||
| Header: 'Post-breach actions that used PowerShell commands/scripts', | |||
There was a problem hiding this comment.
I'd further simplify this to "Post Breach Actions" because there's already a section explaining that Monkey used PowerShell commands.
VakarisZ
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1513
PR Checklist
Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?