Skip to content

Remove "Kill file" config option #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 10, 2021
Merged

Remove "Kill file" config option #1575

merged 5 commits into from
Nov 10, 2021

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Fixes #1536

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running Monkey Island to make sure nothing breaks.

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #1575 (124e9ef) into develop (cb61339) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1575   +/-   ##
========================================
  Coverage    43.95%   43.96%           
========================================
  Files          477      477           
  Lines        14159    14153    -6     
========================================
- Hits          6224     6222    -2     
+ Misses        7935     7931    -4
Impacted Files Coverage Δ
monkey/infection_monkey/config.py 64.23% <ø> (-0.52%) ⬇️
monkey/infection_monkey/main.py 0.00% <ø> (ø)
...onkey_island/cc/services/config_schema/internal.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb61339...124e9ef. Read the comment docs.

@shreyamalviya shreyamalviya merged commit dac2aa5 into develop Nov 10, 2021
@shreyamalviya shreyamalviya deleted the 1536-remove-kill-file branch November 10, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "Kill File"
2 participants
@shreyamalviya @VakarisZ