Skip to content

1567 sambacry removal #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 10, 2021
Merged

1567 sambacry removal #1574

merged 7 commits into from
Nov 10, 2021

Conversation

VakarisZ
Copy link
Contributor

@VakarisZ VakarisZ commented Nov 10, 2021 •
edited by ilija-lazoroski
Loading

What does this PR do?

Fixes #1567

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

Are the commit messages enough? If not, elaborate.

@VakarisZ VakarisZ requested a review from mssalvatore November 10, 2021 10:40
@codecov
Copy link

codecov bot commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #1574 (f5c8db9) into develop (dac2aa5) will increase coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1574      +/-   ##
===========================================
+ Coverage    43.96%   44.78%   +0.82%     
===========================================
  Files          477      475       -2     
  Lines        14153    13884     -269     
===========================================
- Hits          6222     6218       -4     
+ Misses        7931     7666     -265
Impacted Files Coverage Δ
monkey/infection_monkey/config.py 63.43% <ø> (-0.81%) ⬇️
...y/monkey_island/cc/services/config_schema/basic.py 100.00% <ø> (ø)
...ces/config_schema/definitions/exploiter_classes.py 100.00% <ø> (ø)
...onkey_island/cc/services/config_schema/internal.py 100.00% <ø> (ø)
...onkey_island/cc/services/reporting/aws_exporter.py 0.00% <ø> (ø)
...ng/exploit_processing/exploiter_descriptor_enum.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac2aa5...f5c8db9. Read the comment docs.

@VakarisZ VakarisZ marked this pull request as ready for review November 10, 2021 13:37
@VakarisZ VakarisZ force-pushed the 1567-sambacry-removal branch from c11db2f to e68cd86 Compare November 10, 2021 13:41
@VakarisZ VakarisZ force-pushed the 1567-sambacry-removal branch from e68cd86 to f5c8db9 Compare November 10, 2021 13:44
mssalvatore
mssalvatore approved these changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@mssalvatore mssalvatore merged commit 81fb015 into develop Nov 10, 2021
@mssalvatore mssalvatore deleted the 1567-sambacry-removal branch November 10, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove SambaCry exploiter
3 participants
@VakarisZ @ilija-lazoroski @mssalvatore