AppImage and Docker deployment renaming #1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conform to the naming convention of InfectionMonkey-v*.* AppImages are built into InfectionMonkey-v1.11.0.AppImage Docker is build into InfectionMonkey-docker-v1.11.0.tgz
… not specified With this change, Jenkins will output packages in the following naming conventions: Develop: InfectionMonkey-$commit_number_x86_64.AppImage Release: InfectionMonkey-v$version.AppImage
With this change, Jenkins will output docker packages in the following naming conventions: Develop: InfectionMonkey-docker-$commit_number.tgz Release: InfectionMonkey-docker-v$version.tgz
If the version is none (default) the commit number will be used which is preferred in dev environment
Add -C to git command in order to execute rev-parse outside the repo.
a458fe0 to
e406294
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1544 +/- ##
========================================
Coverage 43.45% 43.45%
========================================
Files 480 480
Lines 14285 14285
========================================
Hits 6208 6208
Misses 8077 8077 Continue to review full report at Codecov.
|
c8074c7 to
6d827ad
Compare
mssalvatore
approved these changes
Oct 21, 2021
VakarisZ
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1524 .
Add any further explanations here.
PR Checklist
Testing Checklist
Added relevant unit tests?Explain Changes
Are the commit messages enough? If not, elaborate.