Skip to content

Remove Backdoor user PBA #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 30, 2021
Merged

Remove Backdoor user PBA #1433

merged 4 commits into from
Aug 30, 2021

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Aug 30, 2021 •
edited
Loading

Merge #1434 before this to avoid messy merge conflicts!

What does this PR do?

Fixes part of #1410 .

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

image
image

@shreyamalviya shreyamalviya mentioned this pull request Aug 30, 2021
Merged
7 tasks
@ilija-lazoroski ilija-lazoroski force-pushed the 1410/remove-backdoor-pba branch from a535aa1 to 2df5818 Compare August 30, 2021 10:59
@codecov
Copy link

codecov bot commented Aug 30, 2021 •
edited
Loading

Codecov Report

Merging #1433 (2df5818) into develop (02bd3ef) will decrease coverage by 0.18%.
The diff coverage is 61.53%.

❗ Current head 2df5818 differs from pull request most recent head 1bf3013. Consider uploading reports for the commit 1bf3013 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1433      +/-   ##
===========================================
- Coverage    40.29%   40.10%   -0.19%     
===========================================
  Files          465      463       -2     
  Lines        13836    13818      -18     
===========================================
- Hits          5575     5542      -33     
- Misses        8261     8276      +15
Impacted Files Coverage Δ
...ost_breach/actions/communicate_as_backdoor_user.py 0.00% <0.00%> (ø)
...services/attack/technique_reports/pba_technique.py 44.00% <ø> (ø)
...s/config_schema/definitions/post_breach_actions.py 100.00% <ø> (ø)
.../monkey_island/cc/services/config_schema/monkey.py 100.00% <ø> (ø)
monkey/common/common_consts/post_breach_consts.py 100.00% <100.00%> (ø)
monkey/common/common_consts/zero_trust_consts.py 100.00% <100.00%> (ø)
...land/cc/services/attack/technique_reports/T1136.py 100.00% <100.00%> (ø)
...nd/cc/services/telemetry/processing/post_breach.py 84.21% <100.00%> (ø)
.../zero_trust_checks/communicate_as_backdoor_user.py 57.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02bd3ef...1bf3013. Read the comment docs.

shreyamalviya
shreyamalviya requested changes Aug 30, 2021
View reviewed changes
@ilija-lazoroski ilija-lazoroski force-pushed the 1410/remove-backdoor-pba branch 3 times, most recently from a031b5d to 07039a8 Compare August 30, 2021 11:43
@ilija-lazoroski ilija-lazoroski force-pushed the 1410/remove-backdoor-pba branch from 07039a8 to 1069793 Compare August 30, 2021 12:03
@ilija-lazoroski ilija-lazoroski force-pushed the 1410/remove-backdoor-pba branch from 8d60796 to 7aa230e Compare August 30, 2021 12:22
@mssalvatore mssalvatore merged commit 318e71b into develop Aug 30, 2021
@mssalvatore mssalvatore deleted the 1410/remove-backdoor-pba branch August 30, 2021 13:43
mssalvatore added a commit that referenced this pull request Aug 30, 2021
@mssalvatore
Move changelog entries from PR #1433 from v1.11.0 to unreleased
00ccc37
@shreyamalviya shreyamalviya mentioned this pull request Aug 31, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyamalviya shreyamalviya shreyamalviya requested changes

@mssalvatore mssalvatore mssalvatore approved these changes

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilija-lazoroski @mssalvatore @shreyamalviya