Skip to content

Remove traceroute binaries #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2021
Merged

Remove traceroute binaries #1422

merged 1 commit into from
Aug 20, 2021

Conversation

mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented Aug 20, 2021 •
edited
Loading

Remove traceroute binaries.

Fixes #1397

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running a subset of blackbox tests.

@codecov
Copy link

codecov bot commented Aug 20, 2021 •
edited
Loading

Codecov Report

Merging #1422 (aded0ca) into develop (198fbd6) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head aded0ca differs from pull request most recent head c091070. Consider uploading reports for the commit c091070 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1422      +/-   ##
===========================================
- Coverage    40.06%   40.03%   -0.04%     
===========================================
  Files          465      465              
  Lines        13835    13847      +12     
===========================================
  Hits          5543     5543              
- Misses        8292     8304      +12
Impacted Files Coverage Δ
monkey/infection_monkey/network/ping_scanner.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 198fbd6...c091070. Read the comment docs.

@mssalvatore
Agent: Remove traceroute binaries
c091070 
The traceroute binaries are no longer used. They inflate the size of the
agent binaries and add unnecessary dependencies.
@mssalvatore mssalvatore force-pushed the 1397/remove-traceroute-binaries branch from aded0ca to c091070 Compare August 20, 2021 20:25
@mssalvatore mssalvatore merged commit db8ea45 into develop Aug 20, 2021
@mssalvatore mssalvatore deleted the 1397/remove-traceroute-binaries branch August 20, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyamalviya shreyamalviya shreyamalviya approved these changes

@ilija-lazoroski ilija-lazoroski Awaiting requested review from ilija-lazoroski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove traceroute binaries
2 participants
@mssalvatore @shreyamalviya