Skip to content

Hide description that messed up the list in the UI #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2021
Merged

Hide description that messed up the list in the UI #1414

merged 1 commit into from
Aug 19, 2021

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Aug 16, 2021 •
edited
Loading

What does this PR do?

Fixes #1353 .

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

image

@codecov
Copy link

codecov bot commented Aug 16, 2021 •
edited
Loading

Codecov Report

Merging #1414 (bbf6df6) into develop (dd390ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1414   +/-   ##
========================================
  Coverage    40.07%   40.07%           
========================================
  Files          465      465           
  Lines        13845    13845           
========================================
  Hits          5548     5548           
  Misses        8297     8297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd390ff...bbf6df6. Read the comment docs.

mssalvatore
mssalvatore reviewed Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@mssalvatore mssalvatore left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you looked closely through the rest of the UI to ensure this change doesn't have unintended consequences?

@ilija-lazoroski ilija-lazoroski force-pushed the 1353/messed-up-ui-list branch 2 times, most recently from b5dc65f to bbf6df6 Compare August 18, 2021 09:03
@ilija-lazoroski
Copy link
Contributor Author

There is a class config-template-no-header that is hiding the description of the array items which is messing with the alignment. Apparently was applied to internal but forgotten for exploits and network.

@mssalvatore mssalvatore force-pushed the 1353/messed-up-ui-list branch from bbf6df6 to 33f14b5 Compare August 19, 2021 14:34
@mssalvatore mssalvatore merged commit 8e9f564 into develop Aug 19, 2021
@mssalvatore mssalvatore deleted the 1353/messed-up-ui-list branch August 19, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore left review comments

@shreyamalviya shreyamalviya Awaiting requested review from shreyamalviya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Messed up list UI
2 participants
@ilija-lazoroski @mssalvatore