Skip to content

Ransomware: get unset mode #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2021
Merged

Ransomware: get unset mode #1321

merged 1 commit into from
Jul 14, 2021

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Fixes unset mode for ransomware quickstart start-over task.

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

Are the commit messages enough? If not, elaborate.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #1321 (2a1d41f) into develop (bf517bf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1321      +/-   ##
===========================================
+ Coverage    40.30%   40.31%   +0.01%     
===========================================
  Files          471      471              
  Lines        13823    13826       +3     
===========================================
+ Hits          5571     5574       +3     
  Misses        8252     8252
Impacted Files Coverage Δ
monkey/monkey_island/cc/resources/island_mode.py 100.00% <100.00%> (ø)
...key_island/cc/services/mode/island_mode_service.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf517bf...2a1d41f. Read the comment docs.

@VakarisZ VakarisZ merged commit a77b7ea into develop Jul 14, 2021
@VakarisZ VakarisZ deleted the 1241/ransomware-quickstart-start-over branch July 14, 2021 10:48
@VakarisZ VakarisZ changed the title Ransomware quickstart unset mode to get method in island mode Ransomware: get unset mode Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

@mssalvatore mssalvatore Awaiting requested review from mssalvatore

@shreyamalviya shreyamalviya Awaiting requested review from shreyamalviya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilija-lazoroski @VakarisZ