Skip to content

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Fixes part of #1240.

image

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@ghost
Copy link

ghost commented Jul 13, 2021

Congratulations 🎉. DeepCode analyzed your code in 3.759 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

@VakarisZ VakarisZ marked this pull request as ready for review July 13, 2021 10:47
@VakarisZ VakarisZ force-pushed the ransomware_table_ui branch from e09dc05 to b408c65 Compare July 13, 2021 10:47
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #1317 (3e2cf1d) into develop (3a2f5f5) will not change coverage.
The diff coverage is n/a.

❗ Current head 3e2cf1d differs from pull request most recent head 50cb687. Consider uploading reports for the commit 50cb687 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1317   +/-   ##
========================================
  Coverage    31.10%   31.10%           
========================================
  Files          458      458           
  Lines        13594    13594           
========================================
  Hits          4229     4229           
  Misses        9365     9365           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a2f5f5...50cb687. Read the comment docs.

Comment on lines 28 to 30
<p>
This report shows information about the ransomware simulation run by Infection Monkey.
</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Comment on lines 41 to 44
<p>
This report shows information about the ransomware simulation run by Infection Monkey.
</p>
<div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Comment on lines 5 to 9
if(successful > 0){
return (<p className={"text-success"}>{successful} out of {total}</p>);
} else {
return (<p className={"text-danger"}>{successful} out of {total}</p>);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(successful > 0){
return (<p className={"text-success"}>{successful} out of {total}</p>);
} else {
return (<p className={"text-danger"}>{successful} out of {total}</p>);
}
let textClassName = ""
if(successful > 0){
textClassName = "text-successful"
} else {
textClassName = "text-danger"
}
return (<p className={textClassName}>{successful} out of {total}</p>);

import React from 'react';


function renderFileEncryptionStats(successful: number, total: number) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go in the FileEncryptionTable

@mssalvatore mssalvatore merged commit 8977040 into develop Jul 13, 2021
@mssalvatore mssalvatore deleted the ransomware_table_ui branch July 13, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants