Skip to content

Island UI: fix config import UI bug #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2021
Merged

Island UI: fix config import UI bug #1340

merged 1 commit into from
Jul 20, 2021

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Fixes #1294

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by manually fiddling with the UI

config_ui_bugfix

@codecov
Copy link

codecov bot commented Jul 20, 2021 •
edited
Loading

Codecov Report

Merging #1340 (d9cf282) into develop (0000486) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1340   +/-   ##
========================================
  Coverage    40.31%   40.31%           
========================================
  Files          475      475           
  Lines        13874    13874           
========================================
  Hits          5593     5593           
  Misses        8281     8281

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0000486...d9cf282. Read the comment docs.

@mssalvatore mssalvatore merged commit 42dcb69 into develop Jul 20, 2021
@mssalvatore mssalvatore deleted the config_UI_bug_on_submit branch July 20, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

@mssalvatore mssalvatore mssalvatore approved these changes

@shreyamalviya shreyamalviya Awaiting requested review from shreyamalviya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config fields' values do not change on the tab where the import button is clicked
3 participants
@VakarisZ @ilija-lazoroski @mssalvatore