Skip to content

Ransomware readme behavior #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2021
Merged

Ransomware readme behavior #1275

merged 3 commits into from
Jun 29, 2021

Conversation

mssalvatore
Copy link
Collaborator

What does this PR do?

Issue #1244

Adds functionality to the ransomware payload that leaves a README.txt file in the ransomware target directory after encryption has finished.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running unit tests, running from source, and building and running an agent binary

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Jun 28, 2021 •
edited
Loading

Codecov Report

Merging #1275 (6cba29c) into develop (f7f60be) will increase coverage by 0.04%.
The diff coverage is 83.33%.

❗ Current head 6cba29c differs from pull request most recent head 870fae8. Consider uploading reports for the commit 870fae8 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1275      +/-   ##
===========================================
+ Coverage    30.11%   30.15%   +0.04%     
===========================================
  Files          445      445              
  Lines        13341    13353      +12     
===========================================
+ Hits          4017     4027      +10     
- Misses        9324     9326       +2
Impacted Files Coverage Δ
...key_island/cc/services/config_schema/ransomware.py 100.00% <ø> (ø)
.../infection_monkey/ransomware/ransomware_payload.py 94.82% <83.33%> (-3.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f60be...870fae8. Read the comment docs.

@mssalvatore mssalvatore force-pushed the ransomware-readme-behavior branch from 6cba29c to 870fae8 Compare June 28, 2021 19:39
VakarisZ
VakarisZ requested changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes and can be merged. I'd advise to refactor readme into action before ransomware payload becomes large and cumbersome to refactor

VakarisZ
VakarisZ approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the imports

@mssalvatore mssalvatore force-pushed the ransomware-readme-behavior branch from 870fae8 to 92be6e7 Compare June 29, 2021 15:04
@mssalvatore mssalvatore merged commit 6a67626 into develop Jun 29, 2021
@mssalvatore mssalvatore deleted the ransomware-readme-behavior branch June 29, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

@shreyamalviya shreyamalviya shreyamalviya approved these changes

@ilija-lazoroski ilija-lazoroski Awaiting requested review from ilija-lazoroski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mssalvatore @ilija-lazoroski @VakarisZ @shreyamalviya