Skip to content

Add fields to file encryption telemetry #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 29, 2021
Merged

Add fields to file encryption telemetry #1274

merged 4 commits into from
Jun 29, 2021

Conversation

mssalvatore
Copy link
Collaborator

What does this PR do?

Adds explicit fields to file encryption telemetry.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running unit tests and running locally from source

  • If applicable, add screenshots or log transcripts of the feature working

image

@codecov
Copy link

codecov bot commented Jun 28, 2021 •
edited
Loading

Codecov Report

Merging #1274 (444a18d) into rename-ransomware-telem (49eb1cd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           rename-ransomware-telem    #1274   +/-   ##
========================================================
  Coverage                    30.59%   30.59%           
========================================================
  Files                          448      448           
  Lines                        13417    13417           
========================================================
  Hits                          4105     4105           
  Misses                        9312     9312
Impacted Files Coverage Δ
.../infection_monkey/ransomware/ransomware_payload.py 97.95% <100.00%> (ø)
...nfection_monkey/telemetry/file_encryption_telem.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49eb1cd...444a18d. Read the comment docs.

shreyamalviya
shreyamalviya reviewed Jun 29, 2021
View reviewed changes
monkey/infection_monkey/telemetry/file_encryption_telem.py Outdated
@@ -7,7 +7,7 @@


class FileEncryptionTelem(BatchableTelemMixin, IBatchableTelem, BaseTelem):
def __init__(self, entry: Tuple[str, str]):
def __init__(self, filepath: Path, success: bool, error: str):
"""
File Encryption telemetry constructor
:param attempts: List of tuples with each tuple containing the path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be modified as per changes.

Base automatically changed from rename-ransomware-telem to develop June 29, 2021 15:40
@mssalvatore mssalvatore merged commit 355136a into develop Jun 29, 2021
@mssalvatore mssalvatore deleted the add-fields-to-file-encryption-telemetry branch June 29, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyamalviya shreyamalviya shreyamalviya approved these changes

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mssalvatore @shreyamalviya