Add dlint to flake8 #1124
Merged
Add dlint to flake8 #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VakarisZ
reviewed
Apr 27, 2021
monkey/infection_monkey/dropper.py
Outdated
| @@ -164,9 +165,10 @@ def start(self): | |||
| "monkey_commandline": inner_monkey_cmdline, | |||
| } | |||
|
|
|||
| monkey_cmdline_split = shlex.split(monkey_cmdline) | |||
There was a problem hiding this comment.
Why do we need to split this up? Are you sure that without shell=True this works? Can the command still find environmental variables like %TEMP% or $HOME?
Added comments to ignore some because: "Python uses the Mersenne Twister as the core generator. However, being completely deterministic, it is not suitable for all purposes, and is completely unsuitable for cryptographic purposes. Because the generator is deterministic this means attackers can predict future values given a sufficient amount of previous values. Normal random use is acceptable if the relevant code is not used for security or cryptographic purposes."
(Introduces a DUO116 warning)
by ignoring them
by ignoring them
- monkey/infection_monkey/dropper.py - monkey/infection_monkey/system_info/windows_info_collector.py - monkey/infection_monkey/utils/windows/users.py - monkey/infection_monkey/windows_upgrader.py
…and windows_upgrader
Codecov Report
@@ Coverage Diff @@
## develop #1124 +/- ##
===========================================
- Coverage 28.73% 28.71% -0.02%
===========================================
Files 410 410
Lines 12869 12877 +8
===========================================
Hits 3698 3698
- Misses 9171 9179 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1075
PR Checklist
Testing Checklist
Explain Changes
Are the commit messages enough? If not, elaborate.